RESOLVED FIXED72081
[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests 
https://bugs.webkit.org/show_bug.cgi?id=72081
Summary [chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
James Robinson
Reported 2011-11-10 18:04:46 PST
[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
Attachments
Patch (2.36 KB, patch)
2011-11-10 18:06 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-11-10 18:06:10 PST
Created attachment 114612 [details] Patch
James Robinson
Comment 2 2011-11-10 18:08:23 PST
http://trac.webkit.org/changeset/99844 broke webkit_unit_tests, but only some bots since the failure depends on the order in which the tests are run.
Kenneth Russell
Comment 3 2011-11-10 18:39:30 PST
Comment on attachment 114612 [details] Patch Looks fine. Do you need to do anything with m_rootLayer as well?
James Robinson
Comment 4 2011-11-10 21:32:17 PST
Comment on attachment 114612 [details] Patch Nah, once the two are disentangled dropping the ref on layer is enough for everything to free up.
Hin-Chung Lam
Comment 5 2011-11-11 03:43:10 PST
Whoops! Thanks for fixing this! I'll be more careful about the refs..
Hin-Chung Lam
Comment 6 2011-11-11 04:17:32 PST
Comment on attachment 114612 [details] Patch Clearing flags on attachment: 114612 Committed r99943: <http://trac.webkit.org/changeset/99943>
Hin-Chung Lam
Comment 7 2011-11-11 04:17:39 PST
All reviewed patches have been landed. Closing bug.
Hin-Chung Lam
Comment 8 2011-11-11 04:19:16 PST
Commit queue is stuck so I landed this as: http://trac.webkit.org/changeset/99943
Note You need to log in before you can comment on or make changes to this bug.