Bug 72081 - [chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
Summary: [chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 18:04 PST by James Robinson
Modified: 2011-11-11 04:19 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.36 KB, patch)
2011-11-10 18:06 PST, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-11-10 18:04:46 PST
[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
Comment 1 James Robinson 2011-11-10 18:06:10 PST
Created attachment 114612 [details]
Patch
Comment 2 James Robinson 2011-11-10 18:08:23 PST
http://trac.webkit.org/changeset/99844 broke webkit_unit_tests, but only some bots since the failure depends on the order in which the tests are run.
Comment 3 Kenneth Russell 2011-11-10 18:39:30 PST
Comment on attachment 114612 [details]
Patch

Looks fine. Do you need to do anything with m_rootLayer as well?
Comment 4 James Robinson 2011-11-10 21:32:17 PST
Comment on attachment 114612 [details]
Patch

Nah, once the two are disentangled dropping the ref on layer is enough for everything to free up.
Comment 5 Hin-Chung Lam 2011-11-11 03:43:10 PST
Whoops! Thanks for fixing this! I'll be more careful about the refs..
Comment 6 Hin-Chung Lam 2011-11-11 04:17:32 PST
Comment on attachment 114612 [details]
Patch

Clearing flags on attachment: 114612

Committed r99943: <http://trac.webkit.org/changeset/99943>
Comment 7 Hin-Chung Lam 2011-11-11 04:17:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Hin-Chung Lam 2011-11-11 04:19:16 PST
Commit queue is stuck so I landed this as: http://trac.webkit.org/changeset/99943