Bug 71570 - NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
Summary: NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-04 10:46 PDT by Anders Carlsson
Modified: 2011-11-04 11:13 PDT (History)
0 users

See Also:

Attachments
Patch (8.00 KB, patch)
2011-11-04 10:51 PDT, Anders Carlsson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-11-04 10:46:02 PDT 
NPN_ConvertPoint plug-in test should run from NPP_SetWindow
Comment 1 Anders Carlsson 2011-11-04 10:51:24 PDT 
Created attachment 113679 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-11-04 11:00:26 PDT 
Comment on attachment 113679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113679&action=review

> Tools/ChangeLog:3
> +        NPN_ConvertPoint plug-in test should run from NPP_SetWindow

I don't really understand what this means.
Comment 3 Darin Adler 2011-11-04 11:02:27 PDT 
Comment on attachment 113679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113679&action=review

>> Tools/ChangeLog:3
>> +        NPN_ConvertPoint plug-in test should run from NPP_SetWindow
> 
> I don't really understand what this means.

Maybe “NPP_SetWindow is scary. NPN_ConvertPoint’s best option is to run away, as fast as it can.”
Comment 4 Anders Carlsson 2011-11-04 11:05:58 PDT 
(In reply to comment #3)
> (From update of attachment 113679 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113679&action=review
> 
> >> Tools/ChangeLog:3
> >> +        NPN_ConvertPoint plug-in test should run from NPP_SetWindow
> > 
> > I don't really understand what this means.
> 
> Maybe “NPP_SetWindow is scary. NPN_ConvertPoint’s best option is to run away, as fast as it can.”

LOL. Not sure what I was thinking :) I forgot a "be" but retitled it to "NPN_ConvertPoint plug-in test should be called from NPP_SetWindow"
Comment 5 Anders Carlsson 2011-11-04 11:13:06 PDT 
Committed r99300: <http://trac.webkit.org/changeset/99300>