Bug 71429 - De-virtualize JSObject::defineOwnProperty
Summary: De-virtualize JSObject::defineOwnProperty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 70960
  Show dependency treegraph
 
Reported: 2011-11-02 18:29 PDT by Mark Hahnenberg
Modified: 2011-11-09 02:18 PST (History)
3 users (show)

See Also:


Attachments
Patch (20.77 KB, patch)
2011-11-03 11:15 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (20.81 KB, patch)
2011-11-07 17:00 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-11-02 18:29:35 PDT
We're de-virtualizing JSObject. defineOwnProperty is a virtual method in JSObject.  Thus, we need to de-virtualize defineOwnProperty.  We'll put it in the MethodTable.
Comment 1 Mark Hahnenberg 2011-11-03 11:15:43 PDT
Created attachment 113526 [details]
Patch
Comment 2 Geoffrey Garen 2011-11-03 11:18:55 PDT
Comment on attachment 113526 [details]
Patch

r=me
Comment 3 Mark Hahnenberg 2011-11-07 17:00:40 PST
Created attachment 113960 [details]
Patch
Comment 4 Geoffrey Garen 2011-11-08 16:13:59 PST
Comment on attachment 113960 [details]
Patch

r=me
Comment 5 WebKit Review Bot 2011-11-09 02:18:23 PST
Comment on attachment 113960 [details]
Patch

Clearing flags on attachment: 113960

Committed r99675: <http://trac.webkit.org/changeset/99675>
Comment 6 WebKit Review Bot 2011-11-09 02:18:27 PST
All reviewed patches have been landed.  Closing bug.