Bug 71378 - Remove <track>-related LayoutTests that don't actually work yet
Summary: Remove <track>-related LayoutTests that don't actually work yet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anna Cavender
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-02 11:22 PDT by Anna Cavender
Modified: 2011-11-02 15:43 PDT (History)
2 users (show)

See Also:


Attachments
Patch (139.83 KB, patch)
2011-11-02 11:27 PDT, Anna Cavender
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Cavender 2011-11-02 11:22:15 PDT
There are a number of tests in LayoutTests that don't succeed because the feature is a work in progress and not all functionality is there yet.  This patch removes all the tests that don't work so that they can be more easily added with patches that implement the functionality they test.
Comment 1 Anna Cavender 2011-11-02 11:27:24 PDT
Created attachment 113340 [details]
Patch
Comment 2 Eric Carlson 2011-11-02 11:48:43 PDT
Comment on attachment 113340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113340&action=review

> LayoutTests/platform/qt/Skipped:-260
> -media/track/track-webvtt-tc027-empty-cue.html
> -media/track/track-webvtt-tc028-unsupported-markup.html
> -

Maybe you should add "media/track" because the feature isn't enabled in this port?

> LayoutTests/platform/wk2/Skipped:-908
> -media/track/track-webvtt-tc027-empty-cue.html
> -media/track/track-webvtt-tc028-unsupported-markup.html
> -

Ditto
Comment 3 Anna Cavender 2011-11-02 12:58:15 PDT
Comment on attachment 113340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113340&action=review

>> LayoutTests/platform/qt/Skipped:-260
>> -
> 
> Maybe you should add "media/track" because the feature isn't enabled in this port?

I think track IS enabled on qt.  Notice media/track/track-constants.html and media/track/track-load-* are not skipped and seem to be running fine.

>> LayoutTests/platform/wk2/Skipped:-908
>> -
> 
> Ditto

Ditto for wk2, too.
Comment 4 WebKit Review Bot 2011-11-02 15:43:52 PDT
Comment on attachment 113340 [details]
Patch

Clearing flags on attachment: 113340

Committed r99110: <http://trac.webkit.org/changeset/99110>
Comment 5 WebKit Review Bot 2011-11-02 15:43:57 PDT
All reviewed patches have been landed.  Closing bug.