Bug 71285 - CSSRule: Devirtualize addSubresourceStyleURLs()
Summary: CSSRule: Devirtualize addSubresourceStyleURLs()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-01 07:36 PDT by Andreas Kling
Modified: 2011-11-01 08:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.98 KB, patch)
2011-11-01 07:39 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-01 07:36:06 PDT 
SSIA
Comment 1 Andreas Kling 2011-11-01 07:39:02 PDT 
Created attachment 113171 [details]
Patch
Comment 2 Antti Koivisto 2011-11-01 07:53:45 PDT 
Comment on attachment 113171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113171&action=review

r=me

> Source/WebCore/css/CSSStyleRule.h:59
> -    virtual void addSubresourceStyleURLs(ListHashSet<KURL>& urls);
> +    void addSubresourceStyleURLs(ListHashSet<KURL>& urls);

Something like collectSubresourceURLSs would be a better name and the function should be const. For future refactoring as the name is used in many places.
Comment 3 Andreas Kling 2011-11-01 08:24:31 PDT 
Committed r98963: <http://trac.webkit.org/changeset/98963>