WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71285
CSSRule: Devirtualize addSubresourceStyleURLs()
https://bugs.webkit.org/show_bug.cgi?id=71285
Summary
CSSRule: Devirtualize addSubresourceStyleURLs()
Andreas Kling
Reported
2011-11-01 07:36:06 PDT
SSIA
Attachments
Patch
(3.98 KB, patch)
2011-11-01 07:39 PDT
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-11-01 07:39:02 PDT
Created
attachment 113171
[details]
Patch
Antti Koivisto
Comment 2
2011-11-01 07:53:45 PDT
Comment on
attachment 113171
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=113171&action=review
r=me
> Source/WebCore/css/CSSStyleRule.h:59 > - virtual void addSubresourceStyleURLs(ListHashSet<KURL>& urls); > + void addSubresourceStyleURLs(ListHashSet<KURL>& urls);
Something like collectSubresourceURLSs would be a better name and the function should be const. For future refactoring as the name is used in many places.
Andreas Kling
Comment 3
2011-11-01 08:24:31 PDT
Committed
r98963
: <
http://trac.webkit.org/changeset/98963
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug