Bug 70815 - Web Inspector: redesign workers sidebar pane
Summary: Web Inspector: redesign workers sidebar pane
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 58541
  Show dependency treegraph
 
Reported: 2011-10-25 06:24 PDT by Yury Semikhatsky
Modified: 2011-10-25 08:35 PDT (History)
12 users (show)

See Also:


Attachments
Patch (15.46 KB, patch)
2011-10-25 06:39 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Screenshot with the patch applied (9.68 KB, image/png)
2011-10-25 06:40 PDT, Yury Semikhatsky
no flags Details
Patch (15.50 KB, patch)
2011-10-25 07:47 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff
Screenshot with the patch applied (9.06 KB, image/png)
2011-10-25 07:48 PDT, Yury Semikhatsky
no flags Details
Patch for landing(layout tests fixed) (16.20 KB, patch)
2011-10-25 08:29 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-10-25 06:24:08 PDT
There should be a checkbox that allows starting workers paused, link to a page with a list of all shared workers and a link for each dedicated worker created by inspected page. Clicking on link should open/bring to front a dedicated worker inspector.
Comment 1 Yury Semikhatsky 2011-10-25 06:39:01 PDT
Created attachment 112330 [details]
Patch
Comment 2 Yury Semikhatsky 2011-10-25 06:40:03 PDT
Created attachment 112331 [details]
Screenshot with the patch applied
Comment 3 Pavel Feldman 2011-10-25 06:54:20 PDT
I'd call it "Discover shared workers" and
"Inspect http:// ..."
Comment 4 WebKit Review Bot 2011-10-25 07:02:00 PDT
Comment on attachment 112330 [details]
Patch

Attachment 112330 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10214152

New failing tests:
inspector/styles/styles-add-new-rule.html
inspector/styles/styles-add-blank-property.html
inspector/styles/styles-source-lines.html
inspector/styles/parse-utf8-bom.html
inspector/styles/styles-computed-trace.html
inspector/styles/commit-selector.html
inspector/elements/elements-panel-styles.html
inspector/styles/styles-commit-editing.html
inspector/styles/styles-disable-inherited.html
inspector/styles/styles-iframe.html
inspector/styles/styles-source-lines-inline.html
inspector/styles/styles-add-invalid-property.html
inspector/styles/show-user-agent-styles.html
inspector/elements/elements-delete-inline-style.html
inspector/styles/styles-cancel-editing.html
Comment 5 Yury Semikhatsky 2011-10-25 07:47:10 PDT
Created attachment 112335 [details]
Patch
Comment 6 Yury Semikhatsky 2011-10-25 07:48:18 PDT
Created attachment 112336 [details]
Screenshot with the patch applied
Comment 7 Yury Semikhatsky 2011-10-25 07:48:53 PDT
(In reply to comment #3)
> I'd call it "Discover shared workers" and
Done.

> "Inspect http:// ..."
Changed section separator title to "Dedicated worker inspectors"
Comment 8 Yury Semikhatsky 2011-10-25 08:29:46 PDT
Created attachment 112340 [details]
Patch for landing(layout tests fixed)
Comment 9 Yury Semikhatsky 2011-10-25 08:35:18 PDT
Committed r98348: <http://trac.webkit.org/changeset/98348>