RESOLVED FIXED 70244
Web Inspector: Search matches highlighting in text does not work correctly. 
https://bugs.webkit.org/show_bug.cgi?id=70244
Summary Web Inspector: Search matches highlighting in text does not work correctly.
Vsevolod Vlasov
Reported 2011-10-17 09:19:20 PDT
Search matches highlighting in text does not work correctly. When there are several matches intersecting a particular textNode, then highlighting does now work properly. This functionality is being intensively used for different purposes, needs a test.
Attachments
Patch (15.55 KB, patch)
2011-10-17 09:34 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-10-17 09:34:18 PDT
Created attachment 111275 [details] Patch
WebKit Review Bot
Comment 2 2011-10-17 09:35:33 PDT
Attachment 111275 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 3 2011-10-17 09:44:52 PDT
Comment on attachment 111275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111275&action=review > LayoutTests/inspector/utilities-test.js:3 > +InspectorTest.dumpTextNodesAsString = function(node) Either inline it in the actual test or into inspector-tests.js
Vsevolod Vlasov
Comment 4 2011-10-17 09:56:51 PDT
Committed r97628: <http://trac.webkit.org/changeset/97628>
Note You need to log in before you can comment on or make changes to this bug.