WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70232
[Chromium] Add a missing semi-colon in ExternalPopupMenu.cpp
https://bugs.webkit.org/show_bug.cgi?id=70232
Summary
[Chromium] Add a missing semi-colon in ExternalPopupMenu.cpp
Peter Beverloo
Reported
2011-10-17 07:08:19 PDT
Missing semi-colon. Patch upcoming.
Attachments
Patch
(1.21 KB, patch)
2011-10-17 07:09 PDT
,
Peter Beverloo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Peter Beverloo
Comment 1
2011-10-17 07:09:31 PDT
Created
attachment 111259
[details]
Patch
WebKit Review Bot
Comment 2
2011-10-17 07:11:28 PDT
Attachment 111259
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Last 3072 characters of output: LayoutTests/platform/chromium-win/fast/events/reveal-link-when-focused-expected.txt M LayoutTests/platform/chromium-win/fast/dom/34176-expected.txt M LayoutTests/platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.png M LayoutTests/platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.txt M LayoutTests/platform/chromium-win/css2.1/t0511-c21-pseud-link-03-e-expected.png M LayoutTests/platform/chromium-win/css2.1/t0511-c21-pseud-link-02-e-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug46623
-1-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug8950
-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug51140
-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug7342
-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug51140
-expected.png M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug26553
-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug46623
-1-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug8950
-expected.txt M LayoutTests/platform/chromium-win/tables/mozilla/bugs/
bug7342
-expected.txt M LayoutTests/ChangeLog W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/fast/selectors/017-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/fast/selectors/061-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/
bug46623
-1-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/
bug51140
-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/
bug7342
-expected.png W: -empty_dir: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/
bug8950
-expected.png
r97619
= ec92ce482c58a93dc36cff53dd99607e5a1796a1 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to
http://v8.googlecode.com/svn/branches/3.6@9637
; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to
http://v8.googlecode.com/svn/branches/3.6@9637
; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to
http://v8.googlecode.com/svn/branches/3.6@9637
; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3
2011-10-17 18:33:16 PDT
Comment on
attachment 111259
[details]
Patch Clearing flags on attachment: 111259 Committed
r97694
: <
http://trac.webkit.org/changeset/97694
>
WebKit Review Bot
Comment 4
2011-10-17 18:33:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug