Bug 70230 - CSSParser: Remove unused variable 'propertyComponents'
Summary: CSSParser: Remove unused variable 'propertyComponents'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 05:39 PDT by Andreas Kling
Modified: 2011-10-17 18:06 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (1.17 KB, patch)
2011-10-17 05:42 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-17 05:39:32 PDT
SSIA.
Comment 1 Andreas Kling 2011-10-17 05:42:08 PDT
Created attachment 111250 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-10-17 05:45:13 PDT
Attachment 111250 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Last 3072 characters of output:
cessed: True
    deps_parsed: True
    requirements: ('./', 'chromium_deps', 'third_party')
  
    name: third_party/yasm/source/patched-yasm
    url: From('chromium_deps', 'src/third_party/yasm/source/patched-yasm')
    should_process: True
    requirements: ('./', 'chromium_deps', 'third_party')
  
    name: tools/clang
    url: http://src.chromium.org/svn/trunk/src/tools/clang@105777
    parsed_url: http://src.chromium.org/svn/trunk/src/tools/clang@105777
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./',)
  
    name: tools/generate_stubs
    url: http://src.chromium.org/svn/trunk/src/tools/generate_stubs@105777
    parsed_url: http://src.chromium.org/svn/trunk/src/tools/generate_stubs@105777
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./',)
  
    name: tools/grit
    url: From('chromium_deps', 'src/tools/grit')
    parsed_url: http://grit-i18n.googlecode.com/svn/trunk@6
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./', 'chromium_deps')
  
    name: tools/gritsettings
    url: http://src.chromium.org/svn/trunk/src/tools/gritsettings@105777
    parsed_url: http://src.chromium.org/svn/trunk/src/tools/gritsettings@105777
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./',)
  
    name: tools/gyp
    url: From('chromium_deps', 'src/tools/gyp')
    parsed_url: http://gyp.googlecode.com/svn/trunk@1074
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./', 'chromium_deps')
      name: scons
      url: http://src.chromium.org/svn/trunk/src/third_party/scons@44099
      requirements: ('tools/gyp',)
  
    name: tools/win
    url: http://src.chromium.org/svn/trunk/src/tools/win@105777
    parsed_url: http://src.chromium.org/svn/trunk/src/tools/win@105777
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./',)
  
    name: tools/xdisplaycheck
    url: http://src.chromium.org/svn/trunk/src/tools/xdisplaycheck@105777
    parsed_url: http://src.chromium.org/svn/trunk/src/tools/xdisplaycheck@105777
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./',)
  
    name: ui
    url: http://src.chromium.org/svn/trunk/src/ui@105777
    parsed_url: http://src.chromium.org/svn/trunk/src/ui@105777
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./',)
  
    name: v8
    url: From('chromium_deps', 'src/v8')
    should_process: True
    requirements: ('./', 'chromium_deps')
  
    name: webkit
    url: http://src.chromium.org/svn/trunk/src/webkit@105777
    parsed_url: http://src.chromium.org/svn/trunk/src/webkit@105777
    should_process: True
    processed: True
    deps_parsed: True
    requirements: ('./',)

Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-10-17 18:06:34 PDT
Comment on attachment 111250 [details]
Proposed patch

Clearing flags on attachment: 111250

Committed r97687: <http://trac.webkit.org/changeset/97687>
Comment 4 WebKit Review Bot 2011-10-17 18:06:38 PDT
All reviewed patches have been landed.  Closing bug.