Bug 70135 - [WebKit2][gtk] Re-enable running TestWebKitSettings
Summary: [WebKit2][gtk] Re-enable running TestWebKitSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nayan Kumar K
URL:
Keywords:
Depends on: 70127
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-14 12:51 PDT by Nayan Kumar K
Modified: 2011-12-09 01:02 PST (History)
4 users (show)

See Also:


Attachments
Re-enable running TestWebKitSettings (1.62 KB, patch)
2011-10-14 12:55 PDT, Nayan Kumar K
no flags Details | Formatted Diff | Diff
Re-enable running TestWebKitSettings (2.76 KB, patch)
2011-12-08 22:02 PST, Nayan Kumar K
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nayan Kumar K 2011-10-14 12:51:37 PDT
Re-enable running TestWebKitSettings which was skipped as part of https://bugs.webkit.org/show_bug.cgi?id=70129 due to the bug https://bugs.webkit.org/show_bug.cgi?id=70127.
Comment 1 Nayan Kumar K 2011-10-14 12:55:15 PDT
Created attachment 111058 [details]
Re-enable running TestWebKitSettings
Comment 2 Martin Robinson 2011-12-08 10:09:25 PST
Comment on attachment 111058 [details]
Re-enable running TestWebKitSettings

Thanks for fixing this.
Comment 3 Nayan Kumar K 2011-12-08 22:02:42 PST
Created attachment 118530 [details]
Re-enable running TestWebKitSettings

Unskip 2 skipped tests
Comment 4 WebKit Review Bot 2011-12-08 22:05:06 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 WebKit Review Bot 2011-12-09 01:02:40 PST
Comment on attachment 118530 [details]
Re-enable running TestWebKitSettings

Clearing flags on attachment: 118530

Committed r102444: <http://trac.webkit.org/changeset/102444>
Comment 6 WebKit Review Bot 2011-12-09 01:02:48 PST
All reviewed patches have been landed.  Closing bug.