RESOLVED FIXED 70135
[WebKit2][gtk] Re-enable running TestWebKitSettings 
https://bugs.webkit.org/show_bug.cgi?id=70135
Summary [WebKit2][gtk] Re-enable running TestWebKitSettings
Nayan Kumar K
Reported 2011-10-14 12:51:37 PDT
Re-enable running TestWebKitSettings which was skipped as part of https://bugs.webkit.org/show_bug.cgi?id=70129 due to the bug https://bugs.webkit.org/show_bug.cgi?id=70127.
Attachments
Re-enable running TestWebKitSettings (1.62 KB, patch)
2011-10-14 12:55 PDT, Nayan Kumar K 		no flags
DetailsFormatted DiffDiff
Re-enable running TestWebKitSettings (2.76 KB, patch)
2011-12-08 22:02 PST, Nayan Kumar K 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nayan Kumar K
Comment 1 2011-10-14 12:55:15 PDT
Created attachment 111058 [details] Re-enable running TestWebKitSettings
Martin Robinson
Comment 2 2011-12-08 10:09:25 PST
Comment on attachment 111058 [details] Re-enable running TestWebKitSettings Thanks for fixing this.
Nayan Kumar K
Comment 3 2011-12-08 22:02:42 PST
Created attachment 118530 [details] Re-enable running TestWebKitSettings Unskip 2 skipped tests
WebKit Review Bot
Comment 4 2011-12-08 22:05:06 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Review Bot
Comment 5 2011-12-09 01:02:40 PST
Comment on attachment 118530 [details] Re-enable running TestWebKitSettings Clearing flags on attachment: 118530 Committed r102444: <http://trac.webkit.org/changeset/102444>
WebKit Review Bot
Comment 6 2011-12-09 01:02:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.