RESOLVED FIXED 69520
[Qt][Wk2] Fix build with Qt 5 when QtScript is built as standalone module 
https://bugs.webkit.org/show_bug.cgi?id=69520
Summary [Qt][Wk2] Fix build with Qt 5 when QtScript is built as standalone module
Simon Hausmann
Reported 2011-10-06 05:14:36 PDT
[Qt][Wk2] Fix build with Qt 5 when QtScript is built as standalone module
Attachments
Patch (7.47 KB, patch)
2011-10-06 05:28 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2011-10-06 05:28:01 PDT
Created attachment 109946 [details] Patch
Csaba Osztrogonác
Comment 2 2011-10-06 05:29:01 PDT
Comment on attachment 109946 [details] Patch LGTM, r=me
WebKit Review Bot
Comment 3 2011-10-06 05:53:55 PDT
Comment on attachment 109946 [details] Patch Rejecting attachment 109946 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/9976200
Simon Hausmann
Comment 4 2011-10-06 14:25:38 PDT
Comment on attachment 109946 [details] Patch Clearing flags on attachment: 109946 Committed r96857: <http://trac.webkit.org/changeset/96857>
Simon Hausmann
Comment 5 2011-10-06 14:25:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.