Bug 69299 - On X86, switch bucketCount into a register, timeoutCheck into memory
Summary: On X86, switch bucketCount into a register, timeoutCheck into memory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-03 15:21 PDT by Gavin Barraclough
Modified: 2011-10-03 18:16 PDT (History)
1 user (show)

See Also:


Attachments
Fix (10.06 KB, patch)
2011-10-03 15:45 PDT, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-10-03 15:21:46 PDT
We don't have sufficient registers to keep both in registers, and DFG JIT will trample esi; it doesn't matter if the bucketCount gets stomped on (in fact it may add to randomness!), but it if the timeoutCheck gets trashed we may make calls out to the timout_check stub function too frequently (regressing performance).  This patch has no perf impact on sunspider.
Comment 1 Gavin Barraclough 2011-10-03 15:45:57 PDT
Created attachment 109543 [details]
Fix
Comment 2 Geoffrey Garen 2011-10-03 18:09:24 PDT
Comment on attachment 109543 [details]
Fix

r=me
Comment 3 Gavin Barraclough 2011-10-03 18:16:37 PDT
Fixed in r96563