Bug 69223 - [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
: [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
Status: RESOLVED FIXED
: WebKit
WebKit Qt
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-10-02 08:27 PST by
Modified: 2011-10-03 04:37 PST (History)


Attachments
patch for review. (3.55 KB, patch)
2011-10-02 08:44 PST, Zeno Albisser
noam: review+
noam: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
patch for review. - fixed ChangeLog (3.55 KB, patch)
2011-10-02 11:39 PST, Zeno Albisser
no flags Review Patch | Details | Formatted Diff | Diff
patch for review. (1.02 KB, patch)
2011-10-03 03:27 PST, Zeno Albisser
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-10-02 08:27:18 PST
SSIA
------- Comment #1 From 2011-10-02 08:44:33 PST -------
Created an attachment (id=109422) [details]
patch for review.
------- Comment #2 From 2011-10-02 10:20:39 PST -------
(From update of attachment 109422 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=109422&action=review

Patch looks good, please fix changelog before committing.

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

This won't get committed with OOPS in it... should be something like "No new tests, build fix".
------- Comment #3 From 2011-10-02 11:39:22 PST -------
Created an attachment (id=109425) [details]
patch for review. - fixed ChangeLog
------- Comment #4 From 2011-10-02 12:53:37 PST -------
(From update of attachment 109425 [details])
Clearing flags on attachment: 109425

Committed r96477: <http://trac.webkit.org/changeset/96477>
------- Comment #5 From 2011-10-02 12:53:41 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #6 From 2011-10-03 03:27:39 PST -------
Created an attachment (id=109460) [details]
patch for review.
------- Comment #7 From 2011-10-03 03:28:21 PST -------
WebKitTestRunner does not build yet on mac.
------- Comment #8 From 2011-10-03 04:36:59 PST -------
(From update of attachment 109460 [details])
Clearing flags on attachment: 109460

Committed r96489: <http://trac.webkit.org/changeset/96489>
------- Comment #9 From 2011-10-03 04:37:03 PST -------
All reviewed patches have been landed.  Closing bug.