Bug 69223 - [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
: [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Qt
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Zeno Albisser
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-02 08:27 PDT by Zeno Albisser
Modified: 2011-10-03 04:37 PDT (History)
1 user (show)

See Also:


Attachments
patch for review. (3.55 KB, patch)
2011-10-02 08:44 PDT, Zeno Albisser
noam: review+
noam: commit‑queue-
Details | Formatted Diff | Diff
patch for review. - fixed ChangeLog (3.55 KB, patch)
2011-10-02 11:39 PDT, Zeno Albisser
no flags Details | Formatted Diff | Diff
patch for review. (1.02 KB, patch)
2011-10-03 03:27 PDT, Zeno Albisser
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2011-10-02 08:27:18 PDT
SSIA
Comment 1 Zeno Albisser 2011-10-02 08:44:33 PDT
Created attachment 109422 [details]
patch for review.
Comment 2 Noam Rosenthal 2011-10-02 10:20:39 PDT
Comment on attachment 109422 [details]
patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=109422&action=review

Patch looks good, please fix changelog before committing.

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

This won't get committed with OOPS in it... should be something like "No new tests, build fix".
Comment 3 Zeno Albisser 2011-10-02 11:39:22 PDT
Created attachment 109425 [details]
patch for review. - fixed ChangeLog
Comment 4 WebKit Review Bot 2011-10-02 12:53:37 PDT
Comment on attachment 109425 [details]
patch for review. - fixed ChangeLog

Clearing flags on attachment: 109425

Committed r96477: <http://trac.webkit.org/changeset/96477>
Comment 5 WebKit Review Bot 2011-10-02 12:53:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Zeno Albisser 2011-10-03 03:27:39 PDT
Created attachment 109460 [details]
patch for review.
Comment 7 Zeno Albisser 2011-10-03 03:28:21 PDT
WebKitTestRunner does not build yet on mac.
Comment 8 WebKit Review Bot 2011-10-03 04:36:59 PDT
Comment on attachment 109460 [details]
patch for review.

Clearing flags on attachment: 109460

Committed r96489: <http://trac.webkit.org/changeset/96489>
Comment 9 WebKit Review Bot 2011-10-03 04:37:03 PDT
All reviewed patches have been landed.  Closing bug.