Bug 69120 - add op_call/op_constructor support to JSVALUE32_64 DFG JIT
Summary: add op_call/op_constructor support to JSVALUE32_64 DFG JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 19:18 PDT by Yuqiang Xian
Modified: 2011-09-29 23:16 PDT (History)
2 users (show)

See Also:


Attachments
the patch (8.12 KB, patch)
2011-09-29 19:24 PDT, Yuqiang Xian
no flags Details | Formatted Diff | Diff
patch (8.29 KB, patch)
2011-09-29 20:04 PDT, Yuqiang Xian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuqiang Xian 2011-09-29 19:18:31 PDT
To improve the coverage of JSVALUE32_64 DFG JIT.
Comment 1 Yuqiang Xian 2011-09-29 19:24:00 PDT
Created attachment 109239 [details]
the patch
Comment 2 Yuqiang Xian 2011-09-29 20:04:11 PDT
Created attachment 109245 [details]
patch

forgot to remove NO_RETURN in previous patch.
Comment 3 Gavin Barraclough 2011-09-29 22:12:07 PDT
Comment on attachment 109245 [details]
patch

Looks great.
(r-'ed for a mo there because I thought I'd spotted a problem re stdcall argument popping, but I was wrong!).
Comment 4 WebKit Review Bot 2011-09-29 23:16:19 PDT
Comment on attachment 109245 [details]
patch

Clearing flags on attachment: 109245

Committed r96391: <http://trac.webkit.org/changeset/96391>
Comment 5 WebKit Review Bot 2011-09-29 23:16:23 PDT
All reviewed patches have been landed.  Closing bug.