Bug 69064 - [GTK] Dragging a selection does not produce a drag image
Summary: [GTK] Dragging a selection does not produce a drag image
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 23:42 PDT by Martin Robinson
Modified: 2011-09-29 10:34 PDT (History)
6 users (show)

See Also:


Attachments
Patch (22.32 KB, patch)
2011-09-28 23:59 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (22.56 KB, patch)
2011-09-29 07:06 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-09-28 23:42:15 PDT
When dragging a selection there is no drag image and instead the default icon is used.
Comment 1 Martin Robinson 2011-09-28 23:53:11 PDT
CCing a few more people since my patch touches their work.
Comment 2 Martin Robinson 2011-09-28 23:59:42 PDT
Created attachment 109129 [details]
Patch
Comment 3 WebKit Review Bot 2011-09-29 00:04:27 PDT
Comment on attachment 109129 [details]
Patch

Attachment 109129 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9880826
Comment 4 Gyuyoung Kim 2011-09-29 00:13:00 PDT
Comment on attachment 109129 [details]
Patch

Attachment 109129 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9888426
Comment 5 Martin Robinson 2011-09-29 00:19:24 PDT
Comment on attachment 109129 [details]
Patch

Clearing review flag. I'll fix the bustage tomorrow.
Comment 6 Gustavo Noronha (kov) 2011-09-29 02:08:32 PDT
Comment on attachment 109129 [details]
Patch

Attachment 109129 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9900020
Comment 7 Martin Robinson 2011-09-29 07:06:46 PDT
Created attachment 109157 [details]
Patch
Comment 8 Andreas Kling 2011-09-29 09:00:57 PDT
Comment on attachment 109157 [details]
Patch

Great idea! r=me.
Comment 9 WebKit Review Bot 2011-09-29 10:34:47 PDT
Comment on attachment 109157 [details]
Patch

Clearing flags on attachment: 109157

Committed r96339: <http://trac.webkit.org/changeset/96339>
Comment 10 WebKit Review Bot 2011-09-29 10:34:53 PDT
All reviewed patches have been landed.  Closing bug.