RESOLVED FIXED Bug 68998
Web Inspector: Add support for search in single resource to page agent. 
https://bugs.webkit.org/show_bug.cgi?id=68998
Summary Web Inspector: Add support for search in single resource to page agent.
Vsevolod Vlasov
Reported 2011-09-28 06:03:40 PDT
Add support for search in single resource to page agent.
Attachments
Patch (16.39 KB, patch)
2011-09-28 06:11 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (16.39 KB, patch)
2011-09-28 06:14 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-09-28 06:11:05 PDT
Created attachment 109014 [details] Patch
Vsevolod Vlasov
Comment 2 2011-09-28 06:12:56 PDT
Comment on attachment 109014 [details] Patch Need to fix style, clearing r?.
WebKit Review Bot
Comment 3 2011-09-28 06:13:19 PDT
Attachment 109014 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 Source/WebCore/inspector/InspectorPageAgent.cpp:496: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorPageAgent.h:100: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Vsevolod Vlasov
Comment 4 2011-09-28 06:14:59 PDT
Created attachment 109015 [details] Patch
WebKit Review Bot
Comment 5 2011-09-28 06:18:43 PDT
Attachment 109015 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 Source/WebCore/inspector/InspectorPageAgent.cpp:496: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorPageAgent.h:100: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 6 2011-09-28 06:43:29 PDT
Comment on attachment 109015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109015&action=review > Source/WebCore/inspector/Inspector.json:110 > + { "name": "line", "type": "string", "description": "Line with match." } "name": "lineText" or "name": "lineContent" > Source/WebCore/inspector/InspectorPageAgent.cpp:487 > +static PassRefPtr<InspectorObject> buildObjectForSearchMatch(int lineNumber, String line) Consider moving to ContentSearchUtil > Source/WebCore/inspector/InspectorPageAgent.cpp:522 > + RegularExpression regex = ContentSearchUtils::createSearchRegex(text, false, false); This all could belong to the utility method.
Vsevolod Vlasov
Comment 7 2011-09-28 08:01:00 PDT
Committed r96223: <http://trac.webkit.org/changeset/96223>
Note You need to log in before you can comment on or make changes to this bug.