Bug 68998 - Web Inspector: Add support for search in single resource to page agent.
Summary: Web Inspector: Add support for search in single resource to page agent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 06:03 PDT by Vsevolod Vlasov
Modified: 2011-09-28 08:01 PDT (History)
12 users (show)

See Also:


Attachments
Patch (16.39 KB, patch)
2011-09-28 06:11 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (16.39 KB, patch)
2011-09-28 06:14 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-09-28 06:03:40 PDT
Add support for search in single resource to page agent.
Comment 1 Vsevolod Vlasov 2011-09-28 06:11:05 PDT
Created attachment 109014 [details]
Patch
Comment 2 Vsevolod Vlasov 2011-09-28 06:12:56 PDT
Comment on attachment 109014 [details]
Patch

Need to fix style, clearing r?.
Comment 3 WebKit Review Bot 2011-09-28 06:13:19 PDT
Attachment 109014 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebCore/inspector/InspectorPageAgent.cpp:496:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorPageAgent.h:100:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Vsevolod Vlasov 2011-09-28 06:14:59 PDT
Created attachment 109015 [details]
Patch
Comment 5 WebKit Review Bot 2011-09-28 06:18:43 PDT
Attachment 109015 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebCore/inspector/InspectorPageAgent.cpp:496:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorPageAgent.h:100:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Pavel Feldman 2011-09-28 06:43:29 PDT
Comment on attachment 109015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109015&action=review

> Source/WebCore/inspector/Inspector.json:110
> +                    { "name": "line", "type": "string", "description": "Line with match." }

"name": "lineText" or "name": "lineContent"

> Source/WebCore/inspector/InspectorPageAgent.cpp:487
> +static PassRefPtr<InspectorObject> buildObjectForSearchMatch(int lineNumber, String line)

Consider moving to ContentSearchUtil

> Source/WebCore/inspector/InspectorPageAgent.cpp:522
> +    RegularExpression regex = ContentSearchUtils::createSearchRegex(text, false, false);

This all could belong to the utility method.
Comment 7 Vsevolod Vlasov 2011-09-28 08:01:00 PDT
Committed r96223: <http://trac.webkit.org/changeset/96223>