Bug 68986 - Web Inspector: UI performance test for Inspector start-up time is required
Summary: Web Inspector: UI performance test for Inspector start-up time is required
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 02:13 PDT by Ilya Tikhonovsky
Modified: 2011-09-28 02:29 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.30 KB, patch)
2011-09-28 02:17 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-09-28 02:13:20 PDT
%subj%
Comment 1 Ilya Tikhonovsky 2011-09-28 02:17:12 PDT
Created attachment 108988 [details]
Patch
Comment 2 Yury Semikhatsky 2011-09-28 02:25:21 PDT
Comment on attachment 108988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108988&action=review

> LayoutTests/inspector/performance/resources/inspector-startup-time.html:20
> +    if (new Date() - testStartTime > 20000) {

new Date() -> Date.now()

> LayoutTests/inspector/performance/resources/inspector-startup-time.html:25
> +    layoutTestController.closeWebInspector();

Would be nice to wait until the inspector has closed before starting next performance test.
Comment 3 Ilya Tikhonovsky 2011-09-28 02:29:35 PDT
Committed r96209: <http://trac.webkit.org/changeset/96209>