WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 68340
Implement a CloseEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68340
Summary
Implement a CloseEvent constructor for JSC
Kentaro Hara
Reported
2011-09-19 01:08:14 PDT
CloseEvent should have a constructor (Spec:
http://dev.w3.org/html5/websockets/#closeevent
). After this patch is landed, I will add the CloseEvent constructor for V8 as a follow-up patch.
Attachments
Patch
(17.98 KB, patch)
2011-09-19 02:28 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2011-09-19 02:28:00 PDT
Created
attachment 107819
[details]
Patch
WebKit Review Bot
Comment 2
2011-09-24 03:57:38 PDT
Comment on
attachment 107819
[details]
Patch Rejecting
attachment 107819
[details]
from commit-queue.
haraken@chromium.org
does not have committer permissions according to
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py
. - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 3
2011-09-25 20:29:41 PDT
Comment on
attachment 107819
[details]
Patch Clearing flags on attachment: 107819 Committed
r95931
: <
http://trac.webkit.org/changeset/95931
>
WebKit Review Bot
Comment 4
2011-09-25 20:29:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug