Bug 68340 - Implement a CloseEvent constructor for JSC
Summary: Implement a CloseEvent constructor for JSC
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-09-19 01:08 PDT by Kentaro Hara
Modified: 2011-09-25 20:29 PDT (History)
6 users (show)

See Also:

Patch (17.98 KB, patch)
2011-09-19 02:28 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-09-19 01:08:14 PDT
CloseEvent should have a constructor (Spec: http://dev.w3.org/html5/websockets/#closeevent). 

After this patch is landed, I will add the CloseEvent constructor for V8 as a follow-up patch.
Comment 1 Kentaro Hara 2011-09-19 02:28:00 PDT
Created attachment 107819 [details]
Comment 2 WebKit Review Bot 2011-09-24 03:57:38 PDT
Comment on attachment 107819 [details]

Rejecting attachment 107819 [details] from commit-queue.

haraken@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 WebKit Review Bot 2011-09-25 20:29:41 PDT
Comment on attachment 107819 [details]

Clearing flags on attachment: 107819

Committed r95931: <http://trac.webkit.org/changeset/95931>
Comment 4 WebKit Review Bot 2011-09-25 20:29:46 PDT
All reviewed patches have been landed.  Closing bug.