RESOLVED FIXED Bug 68323
[mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes 
https://bugs.webkit.org/show_bug.cgi?id=68323
Summary [mac] WebKit contains Objective-C classes that are not prefixed with its stan...
mitz
Reported 2011-09-18 11:33:23 PDT
$ nm -jgU JavaScriptCore.framework/JavaScriptCore|egrep '^_OBJC_CLASS_\$_'|egrep -v '\$_(Web|DOM|WK|WTF)' _OBJC_CLASS_$_ProfilerServer $ nm -jgU WebCore.framework/WebCore|egrep '^_OBJC_CLASS_\$_'|egrep -v '\$_(Web|DOM|WK|WTF)' _OBJC_CLASS_$_AccessibilityObjectWrapper _OBJC_CLASS_$_CascadeList _OBJC_CLASS_$_CookieStorageObjCAdapter _OBJC_CLASS_$_LanguageChangeObserver _OBJC_CLASS_$_ScrollAnimationHelperDelegate _OBJC_CLASS_$_ScrollbarPainterControllerDelegate _OBJC_CLASS_$_ScrollbarPainterDelegate _OBJC_CLASS_$_ScrollbarPartAnimation _OBJC_CLASS_$_ScrollbarPrefsObserver $ nm -jgU WebKit.framework/WebKit|egrep '^_OBJC_CLASS_\$_'|egrep -v '\$_(Web|DOM|WK|WTF)' _OBJC_CLASS_$_NonBlockingPanel _OBJC_CLASS_$_PDFPrefUpdatingProxy _OBJC_CLASS_$_ThreadEnabler _OBJC_CLASS_$__WebSafeForwarder $ nm -jgU WebKit2.framework/WebKit2|egrep '^_OBJC_CLASS_\$_'|egrep -v '\$_(Web|DOM|WK|WTF)' _OBJC_CLASS_$_AccessibilityWebPageObject _OBJC_CLASS_$_FullKeyboardAccessWatcher
Attachments
WebKit2 part (48.85 KB, patch)
2011-09-18 12:45 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
WebKit1 part (95.88 KB, patch)
2011-09-18 13:02 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
WebCore part (302.77 KB, patch)
2011-09-18 13:43 PDT, mitz 		sam: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
JavaScriptCore part (3.90 KB, patch)
2011-09-18 16:56 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2011-09-18 11:34:27 PDT
If WTF is not to be considered a standard prefix, then there’s also _OBJC_CLASS_$_WTFMainThreadCaller in JavaScriptCore.
mitz
Comment 2 2011-09-18 12:45:02 PDT
Created attachment 107790 [details] WebKit2 part
mitz
Comment 3 2011-09-18 13:02:45 PDT
Created attachment 107792 [details] WebKit1 part
mitz
Comment 4 2011-09-18 13:43:41 PDT
Created attachment 107795 [details] WebCore part
WebKit Review Bot
Comment 5 2011-09-18 16:26:55 PDT
Comment on attachment 107795 [details] WebCore part Attachment 107795 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9735746 New failing tests: scrollbars/scrollbar-middleclick-nopaste.html scrollbars/scrollbar-orientation.html platform/chromium/fast/text/text-stroke-with-border.html scrollbars/overflow-scrollbar-combinations.html svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html scrollbars/disabled-scrollbar.html scrollbars/scrollbar-buttons.html svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html scrollbars/listbox-scrollbar-combinations.html platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html svg/as-object/embedded-svg-size-changes-no-layout-triggers.html scrollbars/scrollbar-click-does-not-blur-content.html scrollbars/scrollbars-on-positioned-content.html svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html scrollbars/basic-scrollbar.html
mitz
Comment 6 2011-09-18 16:56:58 PDT
Created attachment 107801 [details] JavaScriptCore part
mitz
Comment 7 2011-09-19 11:35:37 PDT
Fixed in <http://trac.webkit.org/r95448>.
Note You need to log in before you can comment on or make changes to this bug.