Bug 67211 - add unittest to validate the complete set of Chromium configurations
Summary: add unittest to validate the complete set of Chromium configurations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-30 10:51 PDT by epoger
Modified: 2011-08-31 13:08 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2011-08-30 10:57 PDT, epoger
no flags Details | Formatted Diff | Diff
Patch (3.94 KB, patch)
2011-08-31 12:02 PDT, epoger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2011-08-30 10:51:33 PDT
See discussion in https://bugs.webkit.org/show_bug.cgi?id=66705
Comment 1 epoger 2011-08-30 10:57:55 PDT
Created attachment 105652 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-31 09:18:07 PDT
Comment on attachment 105652 [details]
Patch

Rejecting attachment 105652 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
4bcac32ccda660ac699e517fce02f8f4886a4dc7
r94194 = 7b05e1067d4781343048ecb521d64b7e72df7cc7
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9572560
Comment 3 epoger 2011-08-31 12:02:06 PDT
Created attachment 105808 [details]
Patch
Comment 4 WebKit Review Bot 2011-08-31 12:03:44 PDT
Comment on attachment 105808 [details]
Patch

Rejecting attachment 105808 [details] from review queue.

epoger@google.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 WebKit Review Bot 2011-08-31 12:04:28 PDT
Comment on attachment 105808 [details]
Patch

Rejecting attachment 105808 [details] from commit-queue.

epoger@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 WebKit Review Bot 2011-08-31 13:08:40 PDT
Comment on attachment 105808 [details]
Patch

Clearing flags on attachment: 105808

Committed r94219: <http://trac.webkit.org/changeset/94219>
Comment 7 WebKit Review Bot 2011-08-31 13:08:44 PDT
All reviewed patches have been landed.  Closing bug.