Bug 66988 - Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot
Summary: Web Inspector: [Chromium] Double clicking on numbers in Count & size columns ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 15:31 PDT by Mikhail Naganov
Modified: 2011-08-26 02:57 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.41 KB, patch)
2011-08-25 15:35 PDT, Mikhail Naganov 		pfeldman: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-08-25 15:31:01 PDT 
From http://code.google.com/p/chromium/issues/detail?id=84659

Chrome Version       : 13.0.782.0
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1.Open the inspector and then Go to profiles
2. Take a heap snapshot.
3. Double click on the entry present in either Count or Shallow Size column.

What is the expected result?
Double clicking on numbers in Count & size columns should toggle between times and percents.

What happens instead?
Double clicking on numbers in Count & size columns doesn't toggle between times and percents.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.0 Safari/535.1
Comment 1 Mikhail Naganov 2011-08-25 15:35:53 PDT 
Created attachment 105264 [details]
Patch
Comment 2 Mikhail Naganov 2011-08-26 02:57:43 PDT 
Manually committed http://trac.webkit.org/changeset/93861

2011-08-26  Mikhail Naganov  <mnaganov@chromium.org>

        Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot.
        https://bugs.webkit.org/show_bug.cgi?id=66988

        Reviewed by Pavel Feldman.

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInContentsGrid):
        (WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):