Bug 66930 - [Qt] REGRESSION(93769): inspector/console/console-tests.html fails
Summary: [Qt] REGRESSION(93769): inspector/console/console-tests.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks: 66861
  Show dependency tree / graph
 
Reported: 2011-08-25 04:43 PDT by Fehér Zsolt
Modified: 2011-08-25 23:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.34 KB, patch)
2011-08-25 06:31 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (10.25 KB, patch)
2011-08-25 06:52 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fehér Zsolt 2011-08-25 04:43:34 PDT 
I am skipping the tests for now.
Comment 1 Fehér Zsolt 2011-08-25 05:06:47 PDT 
The tests were skipped in http://trac.webkit.org/changeset/93775.
Comment 2 Csaba Osztrogonác 2011-08-25 05:33:36 PDT 
diff:

--- /ramdisk/qt-linux-release/build/layout-test-results/inspector/console/console-tests-expected.txt 
+++ /ramdisk/qt-linux-release/build/layout-test-results/inspector/console/console-tests-actual.txt 
@@ -26,7 +26,7 @@
 console-tests.html:11info console-message console-log-level
 console-tests.html:12warn console-message console-warning-level
 console-tests.html:13error console-message console-error-level
-5console-tests.html:15repeated console-message console-log-level repeated-message
+console-tests.html:15repeated console-message console-log-level
 console-tests.html:17count: 1 console-message console-log-level
 console-tests.html:17count: 2 console-message console-log-level
 console-tests.html:18group console-message console-log-level console-group-title

Pavel and/or Yury, have you got any idea?
Comment 3 Pavel Feldman 2011-08-25 05:43:25 PDT 
> Pavel and/or Yury, have you got any idea?

I'll take a look. Probably regressed in http://trac.webkit.org/changeset/93769.
Comment 4 Pavel Feldman 2011-08-25 06:31:59 PDT 
Created attachment 105169 [details]
Patch
Comment 5 Yury Semikhatsky 2011-08-25 06:37:49 PDT 
Comment on attachment 105169 [details]
Patch

Would be nice to complement this with a test.
Comment 6 Pavel Feldman 2011-08-25 06:52:47 PDT 
Created attachment 105175 [details]
Patch
Comment 7 Pavel Feldman 2011-08-25 08:23:05 PDT 
Committed r93786: <http://trac.webkit.org/changeset/93786>
Comment 8 Balazs Kelemen 2011-08-25 09:56:19 PDT 
Thank you very much for the fix.