Bug 66797 - Fix mergeChangeLogs test on native windows
Summary: Fix mergeChangeLogs test on native windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 12:03 PDT by Patrick R. Gansterer
Modified: 2011-08-23 16:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2011-08-23 12:09 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-08-23 12:03:51 PDT 
Fix mergeChangeLogs test on native windows
Comment 1 Patrick R. Gansterer 2011-08-23 12:09:24 PDT 
Created attachment 104884 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-08-23 12:12:32 PDT 
Comment on attachment 104884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104884&action=review

> Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:53
> -        DIR => ($ENV{'TMPDIR'} || "/tmp"),
> +        DIR => ($ENV{'TMPDIR'} || $ENV{'TEMP'} || "/tmp"),

It would be even better to use File::Spec->tmpdir().
Comment 3 WebKit Review Bot 2011-08-23 16:07:34 PDT 
Comment on attachment 104884 [details]
Patch

Clearing flags on attachment: 104884

Committed r93649: <http://trac.webkit.org/changeset/93649>
Comment 4 WebKit Review Bot 2011-08-23 16:07:38 PDT 
All reviewed patches have been landed.  Closing bug.