Bug 66558 - Would like to be able to reuse DynamicDeviceScaleFactor's code in other WebKit-agnostic tests
Summary: Would like to be able to reuse DynamicDeviceScaleFactor's code in other WebKi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 07:35 PDT by Adam Roben (:aroben)
Modified: 2011-08-19 07:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (17.07 KB, patch)
2011-08-19 07:36 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-08-19 07:35:07 PDT 
Would like to be able to reuse DynamicDeviceScaleFactor's code in other WebKit-agnostic tests
Comment 1 Adam Roben (:aroben) 2011-08-19 07:36:21 PDT 
Created attachment 104509 [details]
Patch
Comment 2 Anders Carlsson 2011-08-19 07:42:19 PDT 
Comment on attachment 104509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104509&action=review

> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:33
> +class WebKitAgnosticTest : public ::testing::Test {

Please put a comment here explaining what a WebKitAgnosticTest is, I had a hard time understanding until i saw runWebKit1Test and runWebKit2Test.

> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:53
> +void WebKitAgnosticTest::loadSynchronously(View view, NSURL *url)

Not sure if this is the best name - it's not really doing a synchronous load. Maybe loadAndWaitUntilFinished?
Comment 3 Adam Roben (:aroben) 2011-08-19 07:43:31 PDT 
Comment on attachment 104509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104509&action=review

>> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:33
>> +class WebKitAgnosticTest : public ::testing::Test {
> 
> Please put a comment here explaining what a WebKitAgnosticTest is, I had a hard time understanding until i saw runWebKit1Test and runWebKit2Test.

Added this comment:

This test fixture can be used to write tests that work with both WebKit1 and WebKit2.

>> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:53
>> +void WebKitAgnosticTest::loadSynchronously(View view, NSURL *url)
> 
> Not sure if this is the best name - it's not really doing a synchronous load. Maybe loadAndWaitUntilFinished?

Renamed.
Comment 4 Adam Roben (:aroben) 2011-08-19 07:52:30 PDT 
Committed r93405: <http://trac.webkit.org/changeset/93405>