Bug 65728 – REGRESSION(r92415): Causes many DEBUG crashes (Requested by abarth on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/92415 broke the build:
Causes many DEBUG crashes (Requested by abarth on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 102995 [details]
ROLLOUT of r92415

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Adam Barth]

Looks like this line code code isn't getting if-defed correctly.

#if defined(WEBKIT_HAS_TARGET_IS_XHR)
    case WebURLRequest::TargetIsXHR:
      return ResourceType::XHR;
#endif

[Adam Barth]

--- /mnt/data/b/build/slave/Webkit_Linux__dbg__1_/build/layout-test-results/dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt 
+++ /mnt/data/b/build/slave/Webkit_Linux__dbg__1_/build/layout-test-results/dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE-actual.txt 
@@ -1,1 +1,26 @@
+webkit/support/webkit_support.cc:74: Failure
+Failed
+[11139:11139:9337747628827:FATAL:resource_type.cc(49)] Check failed: false. 
+Backtrace:
+	base::debug::StackTrace::StackTrace() [0x8affb6]
+	logging::LogMessage::~LogMessage() [0x853786]
+	ResourceType::FromTargetType() [0x19ad6c7]
+	webkit_glue::WebURLLoaderImpl::Context::Start() [0x1980b64]
+	webkit_glue::WebURLLoaderImpl::loadSynchronously() [0x19826a4]
+	WebCore::ResourceHandle::loadResourceSynchronously() [0x1a5e6a6]
+	WebCore::FrameLoader::loadResourceSynchronously() [0x137b71d]
+	WebCore::DocumentThreadableLoader::loadRequest() [0x1366405]
+	WebCore::DocumentThreadableLoader::DocumentThreadableLoader() [0x1364372]
+	WebCore::DocumentThreadableLoader::loadResourceSynchronously() [0x136390a]
+	WebCore::ThreadableLoader::loadResourceSynchronously() [0x13a6eb8]
+	WebCore::XMLHttpRequest::createRequest() [0x15654b8]
+	WebCore::XMLHttpRequest::send() [0x1564910]
+	WebCore::XMLHttpRequest::send() [0x156432b]
+	WebCore::V8XMLHttpRequest::sendCallback() [0x116d949]
+	v8::internal::HandleApiCallHelper<>() [0x9fd32a]
+	v8::internal::Builtin_Impl_HandleApiCall() [0x9f7f67]
+	v8::internal::Builtin_HandleApiCall() [0x9f7f38]
+	0x176d5aace14e
+
+

[WebKit Review Bot]

Comment on attachment 102995 [details]
ROLLOUT of r92415

Clearing flags on attachment: 102995

Committed r92424: <http://trac.webkit.org/changeset/92424>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.