Bug 65560 - [chromium] accelerated canvas-to-canvas draws incur an unnecessary readback
Summary: [chromium] accelerated canvas-to-canvas draws incur an unnecessary readback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 12:22 PDT by Stephen White
Modified: 2011-08-02 14:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.58 KB, patch)
2011-08-02 12:26 PDT, Stephen White
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-08-02 12:22:40 PDT
In http://trac.webkit.org/changeset/91870, I added a lockPixels() call to ImageBuffer[Skia]::draw() in order to fix printing, which draws from accelerated->non-accelerated contexts.

However, this causes a readback even in the accelerated->accelerated case, causing a performance slowdown.
Comment 1 Stephen White 2011-08-02 12:26:51 PDT
Created attachment 102680 [details]
Patch
Comment 2 James Robinson 2011-08-02 12:32:05 PDT
Comment on attachment 102680 [details]
Patch

R=me
Comment 3 Stephen White 2011-08-02 14:09:53 PDT
Committed r92227: <http://trac.webkit.org/changeset/92227>