Bug 65154 - Scroll animation refinements.
Summary: Scroll animation refinements.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 17:23 PDT by Scott Byer
Modified: 2011-07-29 12:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (24.16 KB, patch)
2011-07-25 17:32 PDT, Scott Byer 		no flags Details | Formatted Diff | Diff
Patch (24.81 KB, patch)
2011-07-26 15:20 PDT, Scott Byer 		no flags Details | Formatted Diff | Diff
Patch (24.91 KB, patch)
2011-07-29 10:50 PDT, Scott Byer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Byer 2011-07-25 17:23:24 PDT 
Scroll animation refinements.
Comment 1 Scott Byer 2011-07-25 17:32:25 PDT 
Created attachment 101951 [details]
Patch
Comment 2 Scott Byer 2011-07-26 15:20:51 PDT 
Created attachment 102060 [details]
Patch
Comment 3 Adam Barth 2011-07-29 10:42:04 PDT 
Comment on attachment 102060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102060&action=review

> Source/WebCore/platform/ScrollAnimatorNone.h:62
> -        Parameters(bool, double, Curve, double, Curve, double);
> +        Parameters(bool, double, double, Curve, double, Curve, double);

It would be nice to have names for these parameters.
Comment 4 Scott Byer 2011-07-29 10:50:24 PDT 
Created attachment 102374 [details]
Patch
Comment 5 Scott Byer 2011-07-29 10:51:36 PDT 
Agreed, parameter names added in the header.
Comment 6 WebKit Review Bot 2011-07-29 12:12:03 PDT 
Comment on attachment 102374 [details]
Patch

Clearing flags on attachment: 102374

Committed r92002: <http://trac.webkit.org/changeset/92002>
Comment 7 WebKit Review Bot 2011-07-29 12:12:08 PDT 
All reviewed patches have been landed.  Closing bug.