RESOLVED FIXED64814
[Qt] Fix leak of QWebPage in errorPageExtension tests 
https://bugs.webkit.org/show_bug.cgi?id=64814
Summary [Qt] Fix leak of QWebPage in errorPageExtension tests
Caio Marcelo de Oliveira Filho
Reported 2011-07-19 11:10:00 PDT
[Qt] Fix leak of QWebPage in errorPageExtension tests
Attachments
Patch (5.50 KB, patch)
2011-07-19 11:13 PDT, Caio Marcelo de Oliveira Filho 		noam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-07-19 11:13:37 PDT
Created attachment 101346 [details] Patch
Luiz Agostini
Comment 2 2011-07-19 11:43:33 PDT
Comment on attachment 101346 [details] Patch The change in the documentation looks a bit unrelated. Otherwise LGTM.
Noam Rosenthal
Comment 3 2011-07-19 12:44:51 PDT
Comment on attachment 101346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101346&action=review > Source/WebKit/qt/Api/qwebview.cpp:375 > + of the object. If the current page is a child of the web This is unrelated, please remove before committing. You can r=me on it as a separate patch.
Caio Marcelo de Oliveira Filho
Comment 4 2011-07-19 14:31:47 PDT
M Source/WebKit/qt/ChangeLog M Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp Committed r91302
Note You need to log in before you can comment on or make changes to this bug.