Bug 64814 - [Qt] Fix leak of QWebPage in errorPageExtension tests
Summary: [Qt] Fix leak of QWebPage in errorPageExtension tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-19 11:10 PDT by Caio Marcelo de Oliveira Filho
Modified: 2011-07-20 07:18 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.50 KB, patch)
2011-07-19 11:13 PDT, Caio Marcelo de Oliveira Filho
noam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-07-19 11:10:00 PDT
[Qt] Fix leak of QWebPage in errorPageExtension tests
Comment 1 Caio Marcelo de Oliveira Filho 2011-07-19 11:13:37 PDT
Created attachment 101346 [details]
Patch
Comment 2 Luiz Agostini 2011-07-19 11:43:33 PDT
Comment on attachment 101346 [details]
Patch

The change in the documentation looks a bit unrelated.
Otherwise LGTM.
Comment 3 Noam Rosenthal 2011-07-19 12:44:51 PDT
Comment on attachment 101346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101346&action=review

> Source/WebKit/qt/Api/qwebview.cpp:375
> +    of the object. If the current page is a child of the web

This is unrelated, please remove before committing. You can r=me on it as a separate patch.
Comment 4 Caio Marcelo de Oliveira Filho 2011-07-19 14:31:47 PDT
	M	Source/WebKit/qt/ChangeLog
	M	Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
Committed r91302