Bug 64750 - [Chromium] Need to remove app/ from DEPS
Summary: [Chromium] Need to remove app/ from DEPS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://code.google.com/p/chromium/iss...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-18 13:45 PDT by Robert Sesek
Modified: 2011-07-19 13:34 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.11 KB, patch)
2011-07-19 12:06 PDT, Robert Sesek
no flags Details | Formatted Diff | Diff
Patch (3.16 KB, patch)
2011-07-19 12:24 PDT, Robert Sesek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Sesek 2011-07-18 13:45:35 PDT
Downstream is removing /src/app and will move the SQLite abstraction layer to /src/sql. Once this happens, the app directory should be removed from the DEPS file and the Chromium revision rolled forward.
Comment 1 Robert Sesek 2011-07-19 12:06:21 PDT
Created attachment 101357 [details]
Patch
Comment 2 Robert Sesek 2011-07-19 12:08:27 PDT
Comment on attachment 101357 [details]
Patch

James, can you review this?
Comment 3 Tony Chang 2011-07-19 12:18:19 PDT
Comment on attachment 101357 [details]
Patch

We can also remove Source/WebKit/chromium/app/ from .gitignore.
Comment 4 Tony Chang 2011-07-19 12:19:24 PDT
Also, I don't think the directories will get automatically deleted, so I'll try to clean up the bots.
Comment 5 Robert Sesek 2011-07-19 12:24:28 PDT
Created attachment 101362 [details]
Patch
Comment 6 Robert Sesek 2011-07-19 12:25:17 PDT
Comment on attachment 101362 [details]
Patch

Patch updated for .gitignore. Thanks; didn't notice that file.
Comment 7 WebKit Review Bot 2011-07-19 13:34:08 PDT
Comment on attachment 101362 [details]
Patch

Clearing flags on attachment: 101362

Committed r91295: <http://trac.webkit.org/changeset/91295>
Comment 8 WebKit Review Bot 2011-07-19 13:34:12 PDT
All reviewed patches have been landed.  Closing bug.