WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
64750
[Chromium] Need to remove app/ from DEPS
https://bugs.webkit.org/show_bug.cgi?id=64750
Summary
[Chromium] Need to remove app/ from DEPS
Robert Sesek
Reported
2011-07-18 13:45:35 PDT
Downstream is removing /src/app and will move the SQLite abstraction layer to /src/sql. Once this happens, the app directory should be removed from the DEPS file and the Chromium revision rolled forward.
Attachments
Patch
(2.11 KB, patch)
2011-07-19 12:06 PDT
,
Robert Sesek
no flags
Details
Formatted Diff
Diff
Patch
(3.16 KB, patch)
2011-07-19 12:24 PDT
,
Robert Sesek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Robert Sesek
Comment 1
2011-07-19 12:06:21 PDT
Created
attachment 101357
[details]
Patch
Robert Sesek
Comment 2
2011-07-19 12:08:27 PDT
Comment on
attachment 101357
[details]
Patch James, can you review this?
Tony Chang
Comment 3
2011-07-19 12:18:19 PDT
Comment on
attachment 101357
[details]
Patch We can also remove Source/WebKit/chromium/app/ from .gitignore.
Tony Chang
Comment 4
2011-07-19 12:19:24 PDT
Also, I don't think the directories will get automatically deleted, so I'll try to clean up the bots.
Robert Sesek
Comment 5
2011-07-19 12:24:28 PDT
Created
attachment 101362
[details]
Patch
Robert Sesek
Comment 6
2011-07-19 12:25:17 PDT
Comment on
attachment 101362
[details]
Patch Patch updated for .gitignore. Thanks; didn't notice that file.
WebKit Review Bot
Comment 7
2011-07-19 13:34:08 PDT
Comment on
attachment 101362
[details]
Patch Clearing flags on attachment: 101362 Committed
r91295
: <
http://trac.webkit.org/changeset/91295
>
WebKit Review Bot
Comment 8
2011-07-19 13:34:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug