Bug 64460 - Consolidate expectations parsing code.
Summary: Consolidate expectations parsing code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64385
  Show dependency treegraph
 
Reported: 2011-07-13 09:52 PDT by Dimitri Glazkov (Google)
Modified: 2011-07-13 12:37 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.12 KB, patch)
2011-07-13 09:54 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-07-13 09:52:13 PDT
Consolidate expectations parsing code.
Comment 1 Dimitri Glazkov (Google) 2011-07-13 09:54:13 PDT
Created attachment 100680 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-13 10:25:14 PDT
Comment on attachment 100680 [details]
Patch

Rejecting attachment 100680 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
eviewer_by_email
    return self._reviewer_only(self.contributor_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 434, in contributor_by_email
    return self._email_to_contributor_map().get(email)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 403, in _email_to_contributor_map
    assert(email not in self._contributors_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/9023631
Comment 3 Dimitri Glazkov (Google) 2011-07-13 11:42:13 PDT
Comment on attachment 100680 [details]
Patch

next in line.
Comment 4 WebKit Review Bot 2011-07-13 12:37:01 PDT
Comment on attachment 100680 [details]
Patch

Clearing flags on attachment: 100680

Committed r90941: <http://trac.webkit.org/changeset/90941>
Comment 5 WebKit Review Bot 2011-07-13 12:37:05 PDT
All reviewed patches have been landed.  Closing bug.