RESOLVED FIXED 64460
Consolidate expectations parsing code. 
https://bugs.webkit.org/show_bug.cgi?id=64460
Summary Consolidate expectations parsing code.
Dimitri Glazkov (Google)
Reported 2011-07-13 09:52:13 PDT
Consolidate expectations parsing code.
Attachments
Patch (5.12 KB, patch)
2011-07-13 09:54 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-13 09:54:13 PDT
Created attachment 100680 [details] Patch
WebKit Review Bot
Comment 2 2011-07-13 10:25:14 PDT
Comment on attachment 100680 [details] Patch Rejecting attachment 100680 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 Last 500 characters of output: eviewer_by_email return self._reviewer_only(self.contributor_by_email(email)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 434, in contributor_by_email return self._email_to_contributor_map().get(email) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 403, in _email_to_contributor_map assert(email not in self._contributors_by_email) # We should never have duplicate emails. AssertionError Full output: http://queues.webkit.org/results/9023631
Dimitri Glazkov (Google)
Comment 3 2011-07-13 11:42:13 PDT
Comment on attachment 100680 [details] Patch next in line.
WebKit Review Bot
Comment 4 2011-07-13 12:37:01 PDT
Comment on attachment 100680 [details] Patch Clearing flags on attachment: 100680 Committed r90941: <http://trac.webkit.org/changeset/90941>
WebKit Review Bot
Comment 5 2011-07-13 12:37:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.