WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
64208
pull static dashboard files into the appengine server from the chromium repository
https://bugs.webkit.org/show_bug.cgi?id=64208
Summary
pull static dashboard files into the appengine server from the chromium repos...
Ojan Vafai
Reported
2011-07-08 15:26:34 PDT
pull static dashboard files into the appengine server from the chromium repository
Attachments
Patch
(270.87 KB, patch)
2011-07-08 15:30 PDT
,
Ojan Vafai
dpranke
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2011-07-08 15:30:22 PDT
Created
attachment 100169
[details]
Patch
Ojan Vafai
Comment 2
2011-07-08 15:32:13 PDT
The contents of the static-dashboards directory is copied wholesale, unmodified from
http://src.chromium.org/viewvc/chrome/trunk/tools/dashboards/
. I'd prefer to do any style or code changes to those files in a followup patch and have this one focus on just getting the files into the tree without breaking any existing functionality.
Adam Barth
Comment 3
2011-07-08 16:26:41 PDT
Comment on
attachment 100169
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=100169&action=review
I mean, this is really just a rubber stamp. This patch is too large for a real review.
> Tools/TestResultServer/app.yaml:1 > -application: test-results > +application: test-results-test
OOPS!
Dirk Pranke
Comment 4
2011-07-08 16:45:52 PDT
Comment on
attachment 100169
[details]
Patch looks fine.
Ojan Vafai
Comment 5
2011-07-08 17:02:16 PDT
Committed
r90674
: <
http://trac.webkit.org/changeset/90674
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug