Bug 64208 - pull static dashboard files into the appengine server from the chromium repository
Summary: pull static dashboard files into the appengine server from the chromium repos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 15:26 PDT by Ojan Vafai
Modified: 2011-07-08 17:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (270.87 KB, patch)
2011-07-08 15:30 PDT, Ojan Vafai
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-07-08 15:26:34 PDT
pull static dashboard files into the appengine server from the chromium repository
Comment 1 Ojan Vafai 2011-07-08 15:30:22 PDT
Created attachment 100169 [details]
Patch
Comment 2 Ojan Vafai 2011-07-08 15:32:13 PDT
The contents of the static-dashboards directory is copied wholesale, unmodified from http://src.chromium.org/viewvc/chrome/trunk/tools/dashboards/. I'd prefer to do any style or code changes to those files in a followup patch and have this one focus on just getting the files into the tree without breaking any existing functionality.
Comment 3 Adam Barth 2011-07-08 16:26:41 PDT
Comment on attachment 100169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100169&action=review

I mean, this is really just a rubber stamp.  This patch is too large for a real review.

> Tools/TestResultServer/app.yaml:1
> -application: test-results
> +application: test-results-test

OOPS!
Comment 4 Dirk Pranke 2011-07-08 16:45:52 PDT
Comment on attachment 100169 [details]
Patch

looks fine.
Comment 5 Ojan Vafai 2011-07-08 17:02:16 PDT
Committed r90674: <http://trac.webkit.org/changeset/90674>