Bug 64192 - It's hard to tell how many test-webkitpy/test-webkitperl tests failed when looking at build.webkit.org
Summary: It's hard to tell how many test-webkitpy/test-webkitperl tests failed when lo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 11:42 PDT by Adam Roben (:aroben)
Modified: 2011-07-08 12:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.60 KB, patch)
2011-07-08 11:43 PDT, Adam Roben (:aroben) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-07-08 11:42:03 PDT 
It's hard to tell how many test-webkitpy/test-webkitperl tests failed when looking at build.webkit.org
Comment 1 Adam Roben (:aroben) 2011-07-08 11:43:11 PDT 
Created attachment 100141 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-07-08 11:55:37 PDT 
Comment on attachment 100141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100141&action=review

Seems reasonable to me.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:393
> +        regex = re.compile(r'^Failed \d+/\d+ test programs\. (?P<count>\d+)/\d+ subtests failed\.')

These regexps could be compile at class evaluation time instead of function execution time.  Doubt it matters.
Comment 3 Eric Seidel (no email) 2011-07-08 11:56:05 PDT 
You may want wms to check since he's more familiar with this file than I.  But it looks like valid python that should do the job.
Comment 4 Adam Roben (:aroben) 2011-07-08 12:06:00 PDT 
Committed r90650: <http://trac.webkit.org/changeset/90650>