Bug 64153 - sheriffbot is too spammy in IRC
Summary: sheriffbot is too spammy in IRC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 00:28 PDT by Adam Barth
Modified: 2011-07-08 08:58 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.29 KB, patch)
2011-07-08 00:32 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-08 00:28:22 PDT
sheriffbot is too spammy in IRC
Comment 1 Adam Barth 2011-07-08 00:32:00 PDT
Created attachment 100088 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-07-08 02:06:44 PDT
Comment on attachment 100088 [details]
Patch

I like the builder idea.  But I agree, this feature isnt' helping these days.
Comment 3 Adam Roben (:aroben) 2011-07-08 06:38:46 PDT
Comment on attachment 100088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100088&action=review

> Tools/ChangeLog:11
> +        Reporting failures in IRC worked well when the tree was greener than it
> +        is today.  Nowadays, this feature mostly just results in spam about
> +        false positives.  If we reach a greener state, we can bring this code
> +        back.

One particularly painful source of redness that causes sheriffbot issues is flaky tests.
Comment 4 WebKit Review Bot 2011-07-08 08:58:43 PDT
Comment on attachment 100088 [details]
Patch

Clearing flags on attachment: 100088

Committed r90636: <http://trac.webkit.org/changeset/90636>
Comment 5 WebKit Review Bot 2011-07-08 08:58:47 PDT
All reviewed patches have been landed.  Closing bug.