Bug 63873 - ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
Summary: ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-03 04:44 PDT by Vsevolod Vlasov
Modified: 2011-07-04 13:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.01 KB, patch)
2011-07-04 09:34 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-07-03 04:44:01 PDT
ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly.
Comment 1 Vsevolod Vlasov 2011-07-04 09:34:23 PDT
Created attachment 99637 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-07-04 12:47:30 PDT
Comment on attachment 99637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99637&action=review

> Source/WebCore/ChangeLog:9
> +        * loader/ResourceLoadNotifier.cpp:
> +        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

Even for a very simple change like this, having per-function comments in ChangeLog would be helpful.
Comment 3 WebKit Review Bot 2011-07-04 13:28:26 PDT
Comment on attachment 99637 [details]
Patch

Clearing flags on attachment: 99637

Committed r90376: <http://trac.webkit.org/changeset/90376>
Comment 4 WebKit Review Bot 2011-07-04 13:28:31 PDT
All reviewed patches have been landed.  Closing bug.