Bug 63399 - SVGAnimatedType should support SVGLengthList animation
Summary: SVGAnimatedType should support SVGLengthList animation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks: 41761
  Show dependency treegraph
 
Reported: 2011-06-26 06:50 PDT by Dirk Schulze
Modified: 2011-06-27 08:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (44.55 KB, patch)
2011-06-26 12:57 PDT, Dirk Schulze
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-06-26 06:50:47 PDT
SVGAnimatedType should support SVGLengthList animation
Comment 1 Dirk Schulze 2011-06-26 12:57:15 PDT
Created attachment 98638 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-26 12:59:49 PDT
Attachment 98638 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/svg/..." exit_code: 1

Source/WebCore/svg/SVGAnimatedLengthList.cpp:43:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:43:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:54:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:54:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:77:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:77:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:77:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:50:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:50:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:51:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:51:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:53:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:53:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:53:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGLength.h:73:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/svg/SVGLength.h:73:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 16 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Nikolas Zimmermann 2011-06-26 13:49:29 PDT
Comment on attachment 98638 [details]
Patch

Dirk, I love your pace :-) r=me. How many are left? AnimBool? AnimEnum? AnimTrafoList?
Comment 4 Dirk Schulze 2011-06-26 23:16:37 PDT
Committed r89783: <http://trac.webkit.org/changeset/89783>
Comment 5 Csaba Osztrogonác 2011-06-27 01:50:35 PDT
SVG animation pause API is missing in WebKit2, and we always have to add new tests to mac-wk2/Skipped list because of this bug. Guys, could you add this kind of tests automatically to the Skipped list when you add a new test, please?

[WK2] SVG animation pause API missing
 https://bugs.webkit.org/show_bug.cgi?id=63396
Comment 6 Nikolas Zimmermann 2011-06-27 08:41:09 PDT
(In reply to comment #5)
> SVG animation pause API is missing in WebKit2, and we always have to add new tests to mac-wk2/Skipped list because of this bug. Guys, could you add this kind of tests automatically to the Skipped list when you add a new test, please?
> 
> [WK2] SVG animation pause API missing
>  https://bugs.webkit.org/show_bug.cgi?id=63396

Dirk, please remember this when landing the next one!