Bug 63271 - Pass Strings as const references in NetworkResourcesData.h
Summary: Pass Strings as const references in NetworkResourcesData.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 12:20 PDT by Tony Chang
Modified: 2011-06-23 14:40 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.19 KB, patch)
2011-06-23 12:21 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-06-23 12:20:58 PDT
Pass Strings as const references in NetworkResourcesData.h
Comment 1 Tony Chang 2011-06-23 12:21:26 PDT
Created attachment 98379 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-23 12:53:55 PDT
Comment on attachment 98379 [details]
Patch

Clearing flags on attachment: 98379

Committed r89604: <http://trac.webkit.org/changeset/89604>
Comment 3 WebKit Review Bot 2011-06-23 12:54:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Jessie Berlin 2011-06-23 14:16:08 PDT
Looks like this is causing crashes on SL WK2:

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89604%20(12857)/results.html
Comment 5 Jessie Berlin 2011-06-23 14:34:27 PDT
Andreas suggested that I roll this out unless Tony shows up soon to address it.
Comment 6 Jessie Berlin 2011-06-23 14:40:07 PDT
The crash appears to have gone away, so I won't roll this patch out. I will keep an eye on that bot.