Bug 63077 - Remove unsafe static_cast inside the InlineBox hierarchy
Summary: Remove unsafe static_cast inside the InlineBox hierarchy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 10:36 PDT by Julien Chaffraix
Modified: 2011-06-24 14:23 PDT (History)
1 user (show)

See Also:


Attachments
Trivial patch: Add the proper conversion methods and remove static_cast's. (25.33 KB, patch)
2011-06-21 10:44 PDT, Julien Chaffraix
darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-06-21 10:36:59 PDT
Patch forthcoming.
Comment 1 Julien Chaffraix 2011-06-21 10:44:06 PDT
Created attachment 98008 [details]
Trivial patch: Add the proper conversion methods and remove static_cast's.
Comment 2 WebKit Review Bot 2011-06-24 13:46:59 PDT
Comment on attachment 98008 [details]
Trivial patch: Add the proper conversion methods and remove static_cast's.

Rejecting attachment 98008 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
ing/InlineTextBox.h
patching file Source/WebCore/rendering/RenderBlock.cpp
Hunk #1 FAILED at 4095.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.cpp.rej
patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp
patching file Source/WebCore/rendering/RenderText.cpp
patching file Source/WebCore/rendering/RootInlineBox.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8932538
Comment 3 Julien Chaffraix 2011-06-24 14:23:12 PDT
Committed r89704: <http://trac.webkit.org/changeset/89704>