Bug 63065 - IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
Summary: IndexedDB: should throw TypeError when indexedDB.open() name argument is missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 06:35 PDT by Mark Pilgrim (Google)
Modified: 2011-06-21 14:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2011-06-21 06:38 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-06-21 06:35:26 PDT 
Follow-on to bug 62398, which incorrectly fixed this issue. (My bad.) As per WebIDL spec, missing required arguments should throw a TypeError, not a database exception.

Patch + fixed test case attached.
Comment 1 Mark Pilgrim (Google) 2011-06-21 06:38:03 PDT 
Created attachment 97978 [details]
Patch
Comment 2 Hans Wennborg 2011-06-21 06:47:24 PDT 
Looks good to me.
Comment 3 WebKit Review Bot 2011-06-21 14:07:13 PDT 
Comment on attachment 97978 [details]
Patch

Clearing flags on attachment: 97978

Committed r89378: <http://trac.webkit.org/changeset/89378>
Comment 4 WebKit Review Bot 2011-06-21 14:07:18 PDT 
All reviewed patches have been landed.  Closing bug.