Bug 63051 - Web Inspector: [Chromium] Path finding to window objects has stopped working after we started to report DOMWindow URL
Summary: Web Inspector: [Chromium] Path finding to window objects has stopped working ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 00:25 PDT by Mikhail Naganov
Modified: 2011-06-21 02:52 PDT (History)
10 users (show)

See Also:

Attachments
patch (1.31 KB, patch)
2011-06-21 00:27 PDT, Mikhail Naganov 		yurys: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-06-21 00:25:19 PDT 
We need to compare with DOMWindow only the beginning of the object name, not the whole name.
Comment 1 Mikhail Naganov 2011-06-21 00:27:15 PDT 
Created attachment 97941 [details]
patch
Comment 2 Mikhail Naganov 2011-06-21 02:52:53 PDT 
Manually committed http://trac.webkit.org/changeset/89344

2011-06-21  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] Fix path finding to window objects.
        https://bugs.webkit.org/show_bug.cgi?id=63051

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):