Bug 63049 - Web Inspector: [Chromium] Remove old (aggregating) heap profiler
Summary: Web Inspector: [Chromium] Remove old (aggregating) heap profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 00:10 PDT by Mikhail Naganov
Modified: 2011-06-21 12:54 PDT (History)
11 users (show)

See Also:

Attachments
patch (59.51 KB, patch)
2011-06-21 00:13 PDT, Mikhail Naganov 		mnaganov: commit-queue-
Details | Formatted Diff | Diff
fix style violation (59.50 KB, patch)
2011-06-21 00:30 PDT, Mikhail Naganov 		pfeldman: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-06-21 00:10:53 PDT 
Clean up.
Comment 1 Mikhail Naganov 2011-06-21 00:13:46 PDT 
Created attachment 97940 [details]
patch
Comment 2 WebKit Review Bot 2011-06-21 00:16:46 PDT 
Attachment 97940 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InspectorProfilerAgent.h:90:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mikhail Naganov 2011-06-21 00:30:02 PDT 
Created attachment 97943 [details]
fix style violation
Comment 4 Pavel Feldman 2011-06-21 06:56:05 PDT 
Comment on attachment 97943 [details]
fix style violation

View in context: https://bugs.webkit.org/attachment.cgi?id=97943&action=review

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:95
> +    ActivityControlAdapter adapter(control);

ASSERT(control)
Comment 5 Mikhail Naganov 2011-06-21 12:48:46 PDT 
(In reply to comment #4)
> (From update of attachment 97943 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97943&action=review
> 
> > Source/WebCore/bindings/v8/ScriptProfiler.cpp:95
> > +    ActivityControlAdapter adapter(control);
> 
> ASSERT(control)

Done.
Comment 6 Mikhail Naganov 2011-06-21 12:54:04 PDT 
Manually committed http://trac.webkit.org/changeset/89372


2011-06-21  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
        https://bugs.webkit.org/show_bug.cgi?id=63049

        * inspector/profiler/detailed-heapshots-test.js:

2011-06-21  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
        https://bugs.webkit.org/show_bug.cgi?id=63049

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * bindings/v8/ScriptProfiler.cpp:
        (WebCore::ScriptProfiler::takeHeapSnapshot):
        * inspector/Inspector.json:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
        * inspector/InspectorProfilerAgent.h:
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype.get profile):
        (WebInspector.DetailedHeapshotView.prototype.get baseProfile):
        (WebInspector.DetailedHeapshotView.prototype._profiles):
        (WebInspector.DetailedHeapshotProfileType):
        (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
        * inspector/front-end/HeapSnapshotView.js: Removed.
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
        (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/heapProfiler.css:
        * inspector/front-end/inspector.html: