WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62745
Convert WebNSFileManagerExtras.m to Objective-C++
https://bugs.webkit.org/show_bug.cgi?id=62745
Summary
Convert WebNSFileManagerExtras.m to Objective-C++
David Kilzer (:ddkilzer)
Reported
2011-06-15 12:15:35 PDT
Created
attachment 97341
[details]
Patch Reviewed by NOBODY (OOPS!). Source/WebKit: * WebKit.xcodeproj/project.pbxproj: (WebNSFileManagerExtras.m): Rename to WebNSFileManagerExtras.mm and change file type to Objective-C++. Source/WebKit/mac: * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m. (-[NSFileManager _webkit_carbonPathForPath:]): (setMetaData): (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added static_cast<MetaDataInfo *>. (-[NSFileManager _webkit_startupVolumeName]): (fileExists): (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): --- 5 files changed, 217 insertions(+), 192 deletions(-)
Attachments
Patch
(7.17 KB, patch)
2011-06-15 12:15 PDT
,
David Kilzer (:ddkilzer)
joepeck
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2011-06-15 12:17:06 PDT
Attachment 97341
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1 Source/WebKit/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 2
2011-06-15 12:27:17 PDT
Comment on
attachment 97341
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=97341&action=review
> Source/WebKit/mac/ChangeLog:14 > + * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m. > + (-[NSFileManager _webkit_carbonPathForPath:]): > + (setMetaData): > + (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): > + Added static_cast<MetaDataInfo *>. > + (-[NSFileManager _webkit_startupVolumeName]): > + (fileExists): > + (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
In changes like this I normally remove the excess ChangeLog comments. Only lines 7, 10+11 are needed, the others are all not useful and just showed up because of the rename.
David Kilzer (:ddkilzer)
Comment 3
2011-06-15 12:54:59 PDT
Committed
r88968
: <
http://trac.webkit.org/changeset/88968
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug