Bug 62745 – Convert WebNSFileManagerExtras.m to Objective-C++

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[David Kilzer (:ddkilzer)]

Created attachment 97341 [details]
Patch

Reviewed by NOBODY (OOPS!).

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:
(WebNSFileManagerExtras.m): Rename to WebNSFileManagerExtras.mm
and change file type to Objective-C++.

Source/WebKit/mac:

* Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
(-[NSFileManager _webkit_carbonPathForPath:]):
(setMetaData):
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Added static_cast<MetaDataInfo *>.
(-[NSFileManager _webkit_startupVolumeName]):
(fileExists):
(-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
---
 5 files changed, 217 insertions(+), 192 deletions(-)

[WebKit Review Bot]

Attachment 97341 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1

Source/WebKit/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 97341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97341&action=review

> Source/WebKit/mac/ChangeLog:14
> +        * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
> +        (-[NSFileManager _webkit_carbonPathForPath:]):
> +        (setMetaData):
> +        (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
> +        Added static_cast<MetaDataInfo *>.
> +        (-[NSFileManager _webkit_startupVolumeName]):
> +        (fileExists):
> +        (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):

In changes like this I normally remove the excess ChangeLog comments.
Only lines 7, 10+11 are needed, the others are all not useful and just
showed up because of the rename.

[David Kilzer (:ddkilzer)]

Committed r88968: <http://trac.webkit.org/changeset/88968>