WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62266
[EFL] remove adjusting codes for zoom's center coordinate
https://bugs.webkit.org/show_bug.cgi?id=62266
Summary
[EFL] remove adjusting codes for zoom's center coordinate
Eunmi Lee
Reported
2011-06-07 22:41:43 PDT
There are adjusting codes in the ewk_view_zoom_set and ewk_view_zoom_weak_set functions as follows: if (cx >= sd->view.w) cx = sd->view.w - 1; if (cy >= sd->view.h) cy = sd->view.h - 1; if (cx < 0) cx = 0; if (cy < 0) cy = 0; But, it is possible that the application developers don't want to limit the zoom's center coordinate to the viewport for implementing some effects. and center coordinate out of the viewport does not affect to the zoom operation. So, I think we'd better to leave zoom's center coordinate freely.
Attachments
Patch
(2.11 KB, patch)
2011-06-07 22:47 PDT
,
Eunmi Lee
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eunmi Lee
Comment 1
2011-06-07 22:47:05 PDT
Created
attachment 96382
[details]
Patch
Lucas De Marchi
Comment 2
2011-06-08 05:39:51 PDT
CC'ing Antognolli, who wrote this part.
Rafael Antognolli
Comment 3
2011-06-08 06:59:41 PDT
(In reply to
comment #1
)
> Created an attachment (id=96382) [details] > Patch
Looks good to me. Actually, I thought this limit was already removed before.
Antonio Gomes
Comment 4
2011-06-08 09:05:38 PDT
Comment on
attachment 96382
[details]
Patch rs=me
WebKit Review Bot
Comment 5
2011-06-08 09:16:12 PDT
Comment on
attachment 96382
[details]
Patch Clearing flags on attachment: 96382 Committed
r88352
: <
http://trac.webkit.org/changeset/88352
>
WebKit Review Bot
Comment 6
2011-06-08 09:16:17 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug