Bug 62068 – media/video-canvas-alpha.html should be SKIP for GPU MAC

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Anna Cavender]

2d acceleration is not yet supported for mac, so this test should be skipped for now.

[Anna Cavender]

Created attachment 95987 [details]
Patch

[WebKit Review Bot]

Attachment 95987 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
LayoutTests/platform/chromium/test_expectations.txt:4015:  More specific entry on line 2432 overrides line 4015 fast/canvas/canvas-currentColor.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:4016:  More specific entry on line 2520 overrides line 4016 fast/canvas/canvas-fillPath-shadow.html  [test/expectations] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anna Cavender]

Created attachment 95990 [details]
Patch

[WebKit Review Bot]

Attachment 95990 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/platform/chromium/test_expectations.txt:4015:  More specific entry on line 2432 overrides line 4015 fast/canvas/canvas-currentColor.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:4016:  More specific entry on line 2520 overrides line 4016 fast/canvas/canvas-fillPath-shadow.html  [test/expectations] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 95990 [details]
Patch

[optional] you may want to add [Chromium] at the beginning of ChangeLog entry.

[WebKit Review Bot]

Comment on attachment 95990 [details]
Patch

Rejecting attachment 95990 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

Comment on attachment 95990 [details]
Patch

Anna will prepare another patch and ask others to review it.

[Anna Cavender]

Created attachment 96098 [details]
Patch

[WebKit Review Bot]

Comment on attachment 96098 [details]
Patch

Clearing flags on attachment: 96098

Committed r88181: <http://trac.webkit.org/changeset/88181>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.