Bug 62038 - [Cairo] leaks cairo contexts when drawing shadows
Summary: [Cairo] leaks cairo contexts when drawing shadows
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Cairo, Gtk
Depends on:
Blocks:
 
Reported: 2011-06-03 12:10 PDT by Gustavo Noronha (kov)
Modified: 2011-06-03 12:29 PDT (History)
0 users

See Also:

Attachments
Patch (8.98 KB, patch)
2011-06-03 12:24 PDT, Gustavo Noronha (kov) 		gustavo: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2011-06-03 12:10:12 PDT 
There are a couple cairo_t objects being used in ContextShadowCairo that are not being destroyed after being used. We should protect them with RefPtr. Patch incoming.
Comment 1 Gustavo Noronha (kov) 2011-06-03 12:24:42 PDT 
Created attachment 95943 [details]
Patch
Comment 2 Martin Robinson 2011-06-03 12:27:32 PDT 
Comment on attachment 95943 [details]
Patch

Hrm. Are you sure there's a leak here? I don't think we ever need to take ar reference to the return value of context->platformContext()->cr().
Comment 3 Gustavo Noronha (kov) 2011-06-03 12:29:20 PDT 
Comment on attachment 95943 [details]
Patch

False alarm, I failed to check whether ->cr() returned a new ref, assuming it did.