Bug 61844 - Rebaseline Chromium test expectations after V8 update
Summary: Rebaseline Chromium test expectations after V8 update
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 01:16 PDT by Rico Wind
Modified: 2011-06-16 04:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch to update chromium expectations (3.17 KB, patch)
2011-06-01 01:19 PDT, Rico Wind 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
Removed tabs from ChangeLog (3.20 KB, patch)
2011-06-14 01:08 PDT, Rico Wind 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rico Wind 2011-06-01 01:16:50 PDT 
Rebaseline Chromium test expectations after V8 got updated with better spec conformance.
First, we now don't throw when calling setters that are undefined (i.e., invoking a setter where only a getter is defined). 
Secondly, we now pass undefined as the implicit receiver for calls to JS builtins in eval.
Comment 1 Rico Wind 2011-06-01 01:19:30 PDT 
Created attachment 95560 [details]
Patch to update chromium expectations
Comment 2 Rico Wind 2011-06-01 02:42:57 PDT 
We should hold this until we update V8 on monday - we had to revert the V8 roll today
Comment 3 anton muhin 2011-06-01 06:40:03 PDT 
Comment on attachment 95560 [details]
Patch to update chromium expectations

LGTM
Comment 4 Adam Barth 2011-06-01 10:48:37 PDT 
Comment on attachment 95560 [details]
Patch to update chromium expectations

You've got tabs in your ChangeLog.
Comment 5 Rico Wind 2011-06-14 01:08:04 PDT 
Created attachment 97081 [details]
Removed tabs from ChangeLog

Comments addressed
Comment 6 Rico Wind 2011-06-16 04:22:02 PDT 
Parts of this has already been committed as another patch (cl 87858), I will create another patch/bug with only the fast/js/eval-var-decl-expected.txt update (and removal of the test expectation for fast/js/property-getters-and-setters-expected.txt)