Bug 61687 - [Texmap][Qt] Disable accelerated plugins/media until they're working.
Summary: [Texmap][Qt] Disable accelerated plugins/media until they're working.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-05-28 09:28 PDT by Noam Rosenthal
Modified: 2011-05-30 12:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2011-05-28 09:35 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2011-05-28 09:28:45 PDT
This will allow us to enable texture mapper without causing regressions.
Comment 1 Noam Rosenthal 2011-05-28 09:35:44 PDT
Created attachment 95263 [details]
Patch
Comment 2 WebKit Commit Bot 2011-05-30 11:28:21 PDT
Comment on attachment 95263 [details]
Patch

Clearing flags on attachment: 95263

Committed r87694: <http://trac.webkit.org/changeset/87694>
Comment 3 WebKit Commit Bot 2011-05-30 11:28:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Ademar Reis 2011-05-30 12:04:14 PDT
The changelog reads:

"""
Until this works properly, we should indicate that our media implementation in texture mapper doesn't support accelerated compositing.

This makes LayoutTests/compositing/video/* work again.
"""

Does it mean that the current implementation (as in qtwebkit-2.2, for example) is broken? I'm asking because if the plugins are broken with AC, then we better disable it on the branch as well (cherry-pick this commit).
Comment 5 Noam Rosenthal 2011-05-30 12:07:53 PDT
(In reply to comment #4)
> The changelog reads:
> 
> """
> Until this works properly, we should indicate that our media implementation in texture mapper doesn't support accelerated compositing.
> 
> This makes LayoutTests/compositing/video/* work again.
> """
> 
> Does it mean that the current implementation (as in qtwebkit-2.2, for example) is broken? I'm asking because if the plugins are broken with AC, then we better disable it on the branch as well (cherry-pick this commit).
No, this is just for texture-mapper. Doesn't apply to the release branch :)