Bug 61082 - [chromium] Check HUD texture reserve status before using texture
Summary: [chromium] Check HUD texture reserve status before using texture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-18 11:23 PDT by Adrienne Walker
Modified: 2011-05-18 14:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2011-05-18 11:26 PDT, Adrienne Walker 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-05-18 11:23:53 PDT 
[chromium] Check HUD texture reserve status before using texture
Comment 1 Adrienne Walker 2011-05-18 11:26:23 PDT 
Created attachment 93948 [details]
Patch
Comment 2 Adrienne Walker 2011-05-18 11:27:50 PDT 
This is just a strawman patch.  Nat, if you think there's something better we can do (create a smaller HUD?) or an error we can report, feel free to change this.
Comment 3 Adrienne Walker 2011-05-18 11:29:26 PDT 
Er, edited to say that the reason for this patch is because I was bumping into assertion errors where the hud texture couldn't be protected because it didn't exist.  It wasn't being created because it would have pushed texture usage over the memory manager's limit.
Comment 4 James Robinson 2011-05-18 13:29:57 PDT 
Might want to add something to the ChangeLog to make it clear that this only changes stuff behind a flag and shouldn't impact users or tests
Comment 5 Adrienne Walker 2011-05-18 14:16:24 PDT 
Committed r86788: <http://trac.webkit.org/changeset/86788>