Bug 60610 - Remove empty class CallbackGuard
Summary: Remove empty class CallbackGuard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 22:27 PDT by Pratik Solanki
Modified: 2011-05-11 23:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.33 KB, patch)
2011-05-10 22:32 PDT, Pratik Solanki
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-05-10 22:27:51 PDT
CallbackGuard was only used on Tiger and it implementation was deleted in r85036 <http://trac.webkit.org/changeset/85036/trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm>. We can just delete the class and its usage now.
Comment 1 Pratik Solanki 2011-05-10 22:32:36 PDT
Created attachment 93073 [details]
Patch
Comment 2 Andreas Kling 2011-05-11 04:53:08 PDT
Comment on attachment 93073 [details]
Patch

r=me
Comment 3 Pratik Solanki 2011-05-11 22:33:05 PDT
Committed r86309: <http://trac.webkit.org/changeset/86309>
Comment 4 WebKit Review Bot 2011-05-11 23:30:35 PDT
http://trac.webkit.org/changeset/86309 might have broken Leopard Intel Debug (Tests)
The following tests are not passing:
editing/deleting/delete-ligature-001.html
editing/deleting/delete-ligature-002.html
editing/deleting/delete-ligature-003.html
platform/mac/editing/input/devanagari-ligature.html