Bug 60458 - [Qt] fix fast/dom/Geolocation/window-close-crash.html
Summary: [Qt] fix fast/dom/Geolocation/window-close-crash.html
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Mahesh Kulkarni
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-05-09 00:46 PDT by Mahesh Kulkarni
Modified: 2011-05-10 14:08 PDT (History)
9 users (show)

See Also:

Attachments
patch (4.07 KB, patch)
2011-05-09 00:51 PDT, Mahesh Kulkarni 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mahesh Kulkarni 2011-05-09 00:46:34 PDT 
Fix skipped test case for Qt port 

fast/dom/Geolocation/window-close-crash.html
Comment 1 Mahesh Kulkarni 2011-05-09 00:51:49 PDT 
Created attachment 92768 [details]
patch

update all pages with mock position/error/permission.
Comment 2 Andreas Kling 2011-05-09 03:50:33 PDT 
Comment on attachment 92768 [details]
patch

r=me
Comment 3 Mahesh Kulkarni 2011-05-09 04:23:24 PDT 
Committed r86049: <http://trac.webkit.org/changeset/86049>
Comment 4 WebKit Review Bot 2011-05-09 08:46:19 PDT 
http://trac.webkit.org/changeset/86049 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
svg/W3C-SVG-1.1/animate-elem-46-t.svg
Comment 5 Mahesh Kulkarni 2011-05-10 03:42:05 PDT 
Comment on attachment 92768 [details]
patch

false alarm. Patch committed clearing flags.
Comment 6 Ademar Reis 2011-05-10 14:07:06 PDT 
Revision r86049 cherry-picked into qtwebkit-2.2 with commit 44acce9 <http://gitorious.org/webkit/qtwebkit/commit/44acce9>