Bug 6043 - Incorrect selection highlighting in pre-formatted text with tabs
: Incorrect selection highlighting in pre-formatted text with tabs
Status: VERIFIED FIXED
: WebKit
Layout and Rendering
: 420+
: Macintosh Mac OS X 10.4
: P2 Normal
Assigned To:
: http://perldoc.perl.org/perl.html
:
:
:
  Show dependency treegraph
 
Reported: 2005-12-11 08:53 PST by
Modified: 2005-12-26 14:08 PST (History)


Attachments
reduced testcase (225 bytes, text/html)
2005-12-11 10:25 PST, mitz@webkit.org
no flags Details
Correct parameters in calls to RenderText::width() (6.19 KB, patch)
2005-12-11 14:03 PST, mitz@webkit.org
no flags Review Patch | Details | Formatted Diff | Diff
Correct parameters in calls to RenderText::width() (7.87 KB, patch)
2005-12-11 23:27 PST, mitz@webkit.org
darin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2005-12-11 08:53:38 PST
Summary: the selection highlight is painted incorrectly (offset to the right) when you select text on the 
right hand side of the man pages lists, e.g. try to select "references" in "Perl references short introduction". 
It does not happen on the two lines that don't start with a link (perl and perltoc).
------- Comment #1 From 2005-12-11 10:25:32 PST -------
Created an attachment (id=5041) [details]
reduced testcase
------- Comment #2 From 2005-12-11 14:03:00 PST -------
Created an attachment (id=5043) [details]
Correct parameters in calls to RenderText::width()

The fix for rdar://problem/3792529 is porbably responsible for at least one
first-line regression that this patch fixes.
------- Comment #3 From 2005-12-11 14:07:27 PST -------
(From update of attachment 5043 [details])
Looks like there's more to it than this.
------- Comment #4 From 2005-12-11 23:27:43 PST -------
Created an attachment (id=5048) [details]
Correct parameters in calls to RenderText::width()
------- Comment #5 From 2005-12-12 08:56:53 PST -------
(From update of attachment 5048 [details])
r=me

Annoying that the compiler didn't catch this one. Shows that default values for
parameters can cause problems.